[PATCH] libvirt-guests.sh: fix log output with new systemd

[Daniel P. Berrangé]

On Thu, Apr 30, 2020 at 04:58:25PM +0200, Christian Ehrhardt wrote:
> On Thu, Apr 30, 2020 at 2:51 PM Daniel P. Berrangé <berrange at redhat.com> wrote:
> Well it seems I have a reproducible symptom and a fix, but not the
> explanation why the latter fixes the former.
> I'll need to dive into some debug & analysis myself to explain it better.
> I'll be back here once I got time to do that in depth check.
> 
> Until then whoever is affected (should be everyone) can give it a
> thought as well.
> Repro is as easy as
> One console:
> $ journalctl -f -u libvirt-guests
> Other console:
> $ systemctl stop libvirt-guests
> $ systemctl start libvirt-guests
> 
> I see it with 245.4-4ubuntu3 (18.04) I'm not seeing it on
> 237-3ubuntu10.39 (20.04).
> Maybe it is a systemd bug after all?
> I'd be interested to hear if that is/isn't clobbering output for
> anyone else and what your systemd versions are?

FWIW, it works correctly on Fedora 31 with systemd 243.

Apr 30 16:07:27 localhost.localdomain systemd[1]: Starting Suspend/Resume Running libvirt Guests...
Apr 30 16:07:27 localhost.localdomain systemd[1]: Started Suspend/Resume Running libvirt Guests.
Apr 30 16:08:33 localhost.localdomain systemd[1]: Stopping Suspend/Resume Running libvirt Guests...
Apr 30 16:08:33 localhost.localdomain libvirt-guests.sh[2192485]: Running guests on default URI: memtest, memtest1
Apr 30 16:08:33 localhost.localdomain libvirt-guests.sh[2192485]: Suspending guests on default URI...
Apr 30 16:08:33 localhost.localdomain libvirt-guests.sh[2192485]: Suspending memtest: ...
Apr 30 16:08:34 localhost.localdomain libvirt-guests.sh[2192485]: Suspending memtest: done
Apr 30 16:08:34 localhost.localdomain libvirt-guests.sh[2192485]: Suspending memtest1: ...
Apr 30 16:08:35 localhost.localdomain libvirt-guests.sh[2192485]: Suspending memtest1: done
Apr 30 16:08:35 localhost.localdomain systemd[1]: libvirt-guests.service: Succeeded.
Apr 30 16:08:35 localhost.localdomain systemd[1]: Stopped Suspend/Resume Running libvirt Guests.

I'll see if I can do a test with newer systemd too


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|