[RFC PATCH 1/3] qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED

[Eric Blake]

On 4/30/20 9:13 AM, Peter Krempa wrote:
> The capability is asserted if qemu supports the -compat
> deprecated-input= and deprecated-output= settings to control what should
> happen if deprecated fields are used in QMP.
> 
> This will be used for a developer-oriented setting which will aid us in
> catching use of deprecated settings sooner.
> ---
>   src/qemu/qemu_capabilities.c                     | 4 ++++
>   src/qemu/qemu_capabilities.h                     | 1 +
>   tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 +
>   3 files changed, 6 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 47f88481c8..cad65cca65 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -580,6 +580,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>                 "machine.pseries.cap-sbbc",
>                 "machine.pseries.cap-ibs",
>                 "tcg",
> +              "compat-deprecated"
>       );

Missing a trailing comma.

> 
> 
> @@ -4879,6 +4880,9 @@ virQEMUCapsInitQMPVersionCaps(virQEMUCapsPtr qemuCaps)
>       /* TCG couldn't be disabled nor queried until QEMU 2.10 */
>       if (qemuCaps->version < 2010000)
>           virQEMUCapsSet(qemuCaps, QEMU_CAPS_TCG);
> +
> +    if (qemuCaps->version >= 5000050)
> +        virQEMUCapsSet(qemuCaps, QEMU_CAPS_COMPAT_DEPRECATED);
>   }

And of course, this will be reworked if your request to the qemu list to 
make it introspectible is resolved.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org