[PATCH] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer

Jin Yan jinyan12 at huawei.com
Fri Aug 7 08:49:53 UTC 2020


 From 55fce33e9cf2d5ea58ebc44b4d78f9c12122fdcb Mon Sep 17 00:00:00 2001
From: Jin Yan <jinyan12 at huawei.com>
Date: Fri, 7 Aug 2020 15:59:45 +0800
Subject: [PATCH] virnetserver: fix some memory leaks in
  virNetTLSContextReloadForServer

These leaks were introduced in commit 15d280fa97b0, use g_autofree for all
cert_path pointers.

Signed-off-by: Jin Yan <jinyan12 at huawei.com>
---
  src/rpc/virnettlscontext.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
index 168f3010ae..37564db14e 100644
--- a/src/rpc/virnettlscontext.c
+++ b/src/rpc/virnettlscontext.c
@@ -921,10 +921,10 @@ int 
virNetTLSContextReloadForServer(virNetTLSContextPtr ctxt,
  {
      gnutls_certificate_credentials_t x509credBak;
      int err;
-    char *cacert = NULL;
-    char *cacrl = NULL;
-    char *cert = NULL;
-    char *key = NULL;
+    g_autofree char *cacert = NULL;
+    g_autofree char *cacrl = NULL;
+    g_autofree char *cert = NULL;
+    g_autofree char *key = NULL;

      x509credBak = ctxt->x509cred;
      ctxt->x509cred = NULL;
--
2.23.0






More information about the libvir-list mailing list