[libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups

Ján Tomko jtomko at redhat.com
Wed Aug 12 11:59:41 UTC 2020


On a Tuesday in 2020, Pavel Hrdina wrote:
>If we don't have cgroups available and user tries to update blkio
>parameters for running VM it will crash.
>
>It should have been protected by the virCgroupHasController() check but
>it was never called if the API was executed without any flags.
>
>We call virDomainObjGetDefs() which sets `def` and `persistentDef` based
>on the flags and these two variables should be used to figure out if we
>need to update LIVE, CONFIG or both states.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1808293
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200812/717ade89/attachment-0001.sig>


More information about the libvir-list mailing list