[PATCH v2] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer
Daniel Henrique Barboza
danielhb413 at gmail.com
Thu Aug 13 16:29:45 UTC 2020
On 8/13/20 12:37 AM, Jin Yan wrote:
> These leaks were introduced in commit 15d280fa97b0, use g_autofree for all
> cert_path pointers.
>
> Signed-off-by: Jin Yan <jinyan12 at huawei.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> src/rpc/virnettlscontext.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
> index 168f3010ae..37564db14e 100644
> --- a/src/rpc/virnettlscontext.c
> +++ b/src/rpc/virnettlscontext.c
> @@ -921,10 +921,10 @@ int virNetTLSContextReloadForServer(virNetTLSContextPtr ctxt,
> {
> gnutls_certificate_credentials_t x509credBak;
> int err;
> - char *cacert = NULL;
> - char *cacrl = NULL;
> - char *cert = NULL;
> - char *key = NULL;
> + g_autofree char *cacert = NULL;
> + g_autofree char *cacrl = NULL;
> + g_autofree char *cert = NULL;
> + g_autofree char *key = NULL;
>
> x509credBak = ctxt->x509cred;
> ctxt->x509cred = NULL;
>
More information about the libvir-list
mailing list