[PATCH 2/3] virhostcpu.c: skip non x86 hosts in virHostCPUGetMicrocodeVersion()

[Ján Tomko]

On a Monday in 2020, Daniel Henrique Barboza wrote:
>Non-x86 archs does not have a 'microcode' version like x86. This is
>covered already inside the function - just return 0 if no microcode
>is found. Regardless of that, a read of /proc/cpuinfo is always made.
>Each read will invoke the kernel to fill in the CPU details every time.
>
>Now let's consider a non-x86 host, like a Power 9 server with 128 CPUs.
>Each /proc/cpuinfo read will need to fetch data for each CPU and it
>won't even matter because we know beforehand that PowerPC chips don't
>have microcode information.
>
>We can do better for non-x86 hosts by skipping this process entirely.
>
>Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>---
> src/cpu/cpu_x86.c            | 2 +-
> src/qemu/qemu_capabilities.c | 4 ++--
> src/util/virhostcpu.c        | 5 ++++-
> src/util/virhostcpu.h        | 2 +-
> 4 files changed, 8 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200824/dedf8394/attachment-0001.sig>