[libvirt PATCH 5/6] util: virlog: unexport virLogVMessage

Ján Tomko jtomko at redhat.com
Sun Aug 2 22:24:23 UTC 2020


Last usage out of virlog.c was removed by
commit 91268c715cf0293f0751de0450e4d0c06bea18d8
    node_device_udev: remove deprecated logging function

Also drop the virbuffer.h include - it seems it was never used
for anything else than the transitive stdarg.h include.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/libvirt_private.syms | 1 -
 src/util/virlog.c        | 3 ++-
 src/util/virlog.h        | 9 ---------
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index eea31a736d..1fae05057e 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -2474,7 +2474,6 @@ virLogSetFilters;
 virLogSetFromEnv;
 virLogSetOutputs;
 virLogUnlock;
-virLogVMessage;
 
 
 # util/virmacaddr.h
diff --git a/src/util/virlog.c b/src/util/virlog.c
index 983c2565ad..322f9599f6 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -493,7 +493,8 @@ virLogSourceUpdate(virLogSourcePtr source)
  * Call the libvirt logger with some information. Based on the configuration
  * the message may be stored, sent to output or just discarded
  */
-void
+static void
+G_GNUC_PRINTF(7, 0)
 virLogVMessage(virLogSourcePtr source,
                virLogPriority priority,
                const char *filename,
diff --git a/src/util/virlog.h b/src/util/virlog.h
index feb2f85904..9913a194fd 100644
--- a/src/util/virlog.h
+++ b/src/util/virlog.h
@@ -22,7 +22,6 @@
 #pragma once
 
 #include "internal.h"
-#include "virbuffer.h"
 
 #ifdef PACKAGER_VERSION
 # ifdef PACKAGER
@@ -199,14 +198,6 @@ void virLogMessage(virLogSourcePtr source,
                    const char *funcname,
                    virLogMetadataPtr metadata,
                    const char *fmt, ...) G_GNUC_PRINTF(7, 8);
-void virLogVMessage(virLogSourcePtr source,
-                    virLogPriority priority,
-                    const char *filename,
-                    int linenr,
-                    const char *funcname,
-                    virLogMetadataPtr metadata,
-                    const char *fmt,
-                    va_list vargs) G_GNUC_PRINTF(7, 0);
 
 bool virLogProbablyLogMessage(const char *str);
 virLogOutputPtr virLogOutputNew(virLogOutputFunc f,
-- 
2.26.2




More information about the libvir-list mailing list