[libvirt PATCH 6/6] util: delete virStringListFree

Ján Tomko jtomko at redhat.com
Sun Aug 2 22:25:34 UTC 2020


Now that everything uses g_strfreev, this function is no longer
needed.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/libvirt_private.syms |  1 -
 src/util/virstring.c     | 18 ------------------
 src/util/virstring.h     |  1 -
 3 files changed, 20 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index eea31a736d..53d0e02433 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -3216,7 +3216,6 @@ virStringIsEmpty;
 virStringIsPrintable;
 virStringListAdd;
 virStringListAutoFree;
-virStringListFree;
 virStringListFreeCount;
 virStringListGetFirstWithPrefix;
 virStringListHasString;
diff --git a/src/util/virstring.c b/src/util/virstring.c
index b31d4743f2..c31f2ede8f 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -259,24 +259,6 @@ virStringListMerge(char ***dst,
 }
 
 
-/**
- * virStringListFree:
- * @strings: a NULL-terminated array of strings to free
- *
- * Frees a NULL-terminated array of strings, and the array itself.
- * If called on a NULL value, virStringListFree() simply returns.
- */
-void virStringListFree(char **strings)
-{
-    char **tmp = strings;
-    while (tmp && *tmp) {
-        VIR_FREE(*tmp);
-        tmp++;
-    }
-    VIR_FREE(strings);
-}
-
-
 void virStringListAutoFree(char ***strings)
 {
     if (!*strings)
diff --git a/src/util/virstring.h b/src/util/virstring.h
index 462a6c092c..7e6103c9d2 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -47,7 +47,6 @@ void virStringListRemove(char ***strings,
 int virStringListMerge(char ***dst,
                        char ***src);
 
-void virStringListFree(char **strings);
 void virStringListAutoFree(char ***strings);
 void virStringListFreeCount(char **strings,
                             size_t count);
-- 
2.26.2




More information about the libvir-list mailing list