[PATCH 1/4] docs: get rid of 'make check' references

Daniel Henrique Barboza danielhb413 at gmail.com
Thu Aug 6 13:34:51 UTC 2020


Update the remaining 'make check' references after the
switch to meson/ninja.

The reference in testsuites.html.in was kept with a note that it is
the process for Libvirt 6.6.0 and older.

Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
---
 docs/advanced-tests.rst    | 2 +-
 docs/api_extension.html.in | 9 ++++-----
 docs/testsuites.html.in    | 3 ++-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/docs/advanced-tests.rst b/docs/advanced-tests.rst
index bc20bbf4d9..458a9105b6 100644
--- a/docs/advanced-tests.rst
+++ b/docs/advanced-tests.rst
@@ -90,7 +90,7 @@ location where the file is stored.
   $ VIR_TEST_FILE_ACCESS=1 VIR_TEST_FILE_ACCESS_OUTPUT="/tmp/file_access.txt" ./qemuxml2argvtest
 
 #. The Valgrind test should produce similar output to
-``make check``. If the output has traces within libvirt API's,
+``ninja test``. If the output has traces within libvirt API's,
 then investigation is required in order to determine the cause
 of the issue. Output such as the following indicates some sort
 of leak:
diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
index 79e7913c1a..6c64e83314 100644
--- a/docs/api_extension.html.in
+++ b/docs/api_extension.html.in
@@ -361,11 +361,10 @@
     </p>
 
     <p>
-      Once you have working functionality, run make check and make
-      syntax-check on each patch of the series before submitting
-      patches.  It may also be worth writing tests for the libvirt-TCK
-      testsuite to exercise your new API, although those patches are
-      not kept in the libvirt repository.
+      Once you have working functionality, run ninja test on each patch
+      of the series before submitting patches. It may also be worth
+      writing tests for the libvirt-TCK testsuite to exercise your new API,
+      although those patches are not kept in the libvirt repository.
     </p>
   </body>
 </html>
diff --git a/docs/testsuites.html.in b/docs/testsuites.html.in
index a619e6d000..cd9cad9160 100644
--- a/docs/testsuites.html.in
+++ b/docs/testsuites.html.in
@@ -10,7 +10,8 @@
           by developers before submitting patches upstream, it is also
           suggested to have it run and pass as part of the packaging
           process for distributions. It is run by launching:
-          <pre>make check</pre>
+          <pre>make check (libvirt 6.6.0 and older)</pre>
+          <pre>ninja test (libvirt 6.7.0 and newer)</pre>
           in a source tree after compilation has finished. It doesn't
           really make functional testing but checks that large portions
           of the code not interacting directly with virtualization
-- 
2.26.2




More information about the libvir-list mailing list