[PATCH] qemu: Move virQEMUFileOpenAs to qemu_domain.c

Daniel P. Berrangé berrange at redhat.com
Mon Aug 24 16:09:20 UTC 2020


On Mon, Aug 24, 2020 at 05:52:00PM +0200, Peter Krempa wrote:
> Commit 43620689794507308fbd3def6992a68ee2f8fa97 moved the function to
> util/virqemu.c which is compiled also on win32 and geteuid()/getegid()
> doesn't exist there.
> 
> Move it to qemu_domain.c which is compiled only when the qemu driver is
> enabled. Originally I didn't want to put it here as qemu_domain.c is a
> code dump for helper functions but this is the least invasive fix.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/libvirt_private.syms |   1 -
>  src/qemu/qemu_domain.c   | 124 +++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_domain.h   |   7 +++
>  src/util/virqemu.c       | 130 ---------------------------------------
>  src/util/virqemu.h       |   7 ---
>  5 files changed, 131 insertions(+), 138 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list