[libvirt PATCH 0/9] qemu: report guest disks informations

[Marc-André Lureau]

Hi

On Mon, Nov 30, 2020 at 11:16 PM Michal Privoznik <mprivozn at redhat.com> wrote:
>
> On 11/20/20 7:09 PM, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > Hi,
> >
> > The following series extends virDomainGetGuestInfo to report disk informations
> > provided by the new QGA "guest-get-disks" command in QEMU 5.2.
> >
> > Please review,
> >
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1899527
> >
> > Marc-André Lureau (9):
> >    qemu_agent: rename qemuAgentDiskInfo->qemuAgentDiskAddress
> >    qemu_agent: export qemuAgentDiskAddressFree & add g_auto
> >    qemu_agent: factor out qemuAgentGetDiskAddress
> >    util: json: add virJSONValueObjectGetStringArray convenience
> >    qemu: use virJSONValueObjectGetStringArray
> >    qemu_agent: add qemuAgentGetDisks
> >    domain: add disk informations to virDomainGetGuestInfo
> >    qemu_driver: report guest disk informations
> >    virsh: add --disk informations to guestinfo command
> >
> >   include/libvirt/libvirt-domain.h |   1 +
> >   src/libvirt-domain.c             |  17 +++
> >   src/libvirt_private.syms         |   1 +
> >   src/qemu/qemu_agent.c            | 182 +++++++++++++++++++++++--------
> >   src/qemu/qemu_agent.h            |  25 ++++-
> >   src/qemu/qemu_driver.c           | 103 ++++++++++++++++-
> >   src/qemu/qemu_monitor_json.c     |  34 +-----
> >   src/util/virjson.c               |  30 +++++
> >   src/util/virjson.h               |   1 +
> >   tests/qemuagenttest.c            | 111 +++++++++++++++++++
> >   tools/virsh-domain.c             |   6 +
> >   11 files changed, 430 insertions(+), 81 deletions(-)
> >
>
> Patches look good. A huge sorry for letting these slip the release. To
> make it up to you, I'm proposing couple of adjustments and if you agree
> I will squash in proposed diffs before pushing - so that you don't have
> to send v2.
>


Fine to me,

> Tentative:
> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
>

thanks!