[PATCH 14/21] domain_conf.c: remove 'error' label in virDomainDefTunablesParse()

Michal Privoznik mprivozn at redhat.com
Tue Dec 1 18:46:52 UTC 2020


On 11/24/20 8:20 PM, Daniel Henrique Barboza wrote:
> The 'error' label is just doing a 'return -1'.
> 
> There's also a couple of 'VIR_FREE(nodes)' calls that are happening
> right before exiting on error, but 'nodes' is already set for
> autocleanup. These calls can also be removed.
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>   src/conf/domain_conf.c | 77 ++++++++++++++++++++----------------------
>   1 file changed, 36 insertions(+), 41 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list