[PATCH 2/3] qemu: support append param on live attaching file chardev

[Peter Krempa]

On Wed, Dec 02, 2020 at 14:55:08 +0300, Nikolay Shirokovskiy wrote:
> Currently it is simply ignored.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  src/qemu/qemu_monitor_json.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 47ee1ff..df95a4a 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -7497,6 +7497,9 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID,
>          backend_type = "file";
>          if (virJSONValueObjectAppendString(data, "out", chr->data.file.path) < 0)
>              goto cleanup;
> +        if (virJSONValueObjectAppendBooleanTristate(data, "append",
> +                                                    chr->data.file.append) < 0)
> +            goto cleanup;

You can use:

if (virJSONValueObjectAdd(data,
                          "T:append", chr->data.file.append,
                          NULL) < 0)
    goto cleanup;


instead of adding the new function at all.