[PATCH 00/11] virDomainCheckpointAlignDisks: Clean up similarly to virDomainSnapshotAlignDisks

Ján Tomko jtomko at redhat.com
Wed Dec 2 15:59:21 UTC 2020


On a Wednesday in 2020, Peter Krempa wrote:
>I've refactored virDomainSnapshotAlignDisks and
>virDomainCheckpointAlignDisks was heavily inspired by it. Clean it up
>too.
>
>Peter Krempa (11):
>  virDomainCheckpointAlignDisks: Refactor cleanup
>  virDomainCheckpointAlignDisks: Unbreak error message
>  virDomainCheckpointAlignDisks: Use 'domdef' for domain definition
>  virDomainCheckpointAlignDisks: rename 'def' to 'chkdef'
>  virDomainCheckpointAlignDisks: Use 'chkdisk' instead of 'disk'
>  virDomainCheckpointAlignDisks: Extract domain disk def pointer to
>    'domdisk'
>  virDomainCheckpointAlignDisks: refactor extension to all disks
>  virDomainCheckpointDiskDef: Remove unused 'idx' field
>  virDomainDiskByName: Remove ternary operator
>  virDomainCheckpointAlignDisks: Use virDomainDiskByName
>  virDomainSnapshotAlignDisks: Use virDomainDiskByName
>
> src/conf/checkpoint_conf.c | 123 ++++++++++++++++---------------------
> src/conf/checkpoint_conf.h |   1 -
> src/conf/domain_conf.c     |   6 +-
> src/conf/snapshot_conf.c   |   7 +--
> 4 files changed, 61 insertions(+), 76 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201202/30c2d032/attachment-0001.sig>


More information about the libvir-list mailing list