[PATCH v2 04/27] domain_conf: Check NVDIMM UUID in ABI stability

Peter Krempa pkrempa at redhat.com
Fri Dec 4 07:04:44 UTC 2020


On Thu, Dec 03, 2020 at 13:36:07 +0100, Michal Privoznik wrote:
> The UUID is guest visible and thus shouldn't change if we want to
> not break guest ABI.
> 
> Fixes: 08ed673901bb5b4f419b37bcce9b11d31ce370e6
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/domain_conf.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Neither the libvirt commit nor the qemu commit mention this fact
clearly. Libvirt doesn't store it under <target> either, which doesn't
entirely substantiate the claim, but it makes sense that it's the same
since it's an uuid and also it's formatted as part of the frontend
definiton on the command line.

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list