[PATCH v2 10/27] qemu: Move mem validation into post parse validator

Peter Krempa pkrempa at redhat.com
Fri Dec 4 07:37:01 UTC 2020


On Thu, Dec 03, 2020 at 13:36:13 +0100, Michal Privoznik wrote:
> There is this function qemuDomainDefValidateMemoryHotplug() which
> is called explicitly from hotplug path and the qemu's domain def
> validator. This is not really necessary because we can move the
> part that validates feature against qemuCaps into device
> validator which is called implicitly (from qemu driver's POV).
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_domain.c   | 32 +-------------------------------
>  src/qemu/qemu_validate.c | 16 +++++++++++++++-
>  2 files changed, 16 insertions(+), 32 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 19a699540f..e705e8d8d5 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -8544,14 +8544,12 @@ qemuDomainDefValidateMemoryHotplugDevice(const virDomainMemoryDef *mem,
>   */
>  int
>  qemuDomainDefValidateMemoryHotplug(const virDomainDef *def,
> -                                   virQEMUCapsPtr qemuCaps,
> +                                   virQEMUCapsPtr qemuCaps G_GNUC_UNUSED,

Actually, I'm missing a patch removing this now-unused argument.




More information about the libvir-list mailing list