[PATCH v2] spec: don't touch existing nwfilters on update
Michal Privoznik
mprivozn at redhat.com
Mon Dec 7 12:21:50 UTC 2020
On 12/7/20 9:38 AM, Nikolay Shirokovskiy wrote:
> Nwfilter can be edited by the user and we don't want to overwrite the editings.
> Also the filters in %{datadir} does not have UUIDs and these are generated on
> libvirtd start. Thus this patch also fixes regeneration of UUIDs on libvirtd
> update.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>
> It is a successor to original version of the patch [1]. The discussion can
> be found in [2].
>
> Diff to v1:
> - just keep existing nwfilters untouched instead of bringing new
> version of nwfilter while keeping UUID
>
> [1] https://www.redhat.com/archives/libvir-list/2020-October/msg01357.html
> [2] https://www.redhat.com/archives/libvir-list/2020-December/msg00260.html
>
> libvirt.spec.in | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
But you may want to wait for Andrea's approval, since he's suggested it.
Michal
More information about the libvir-list
mailing list