[PATCH 2/2] qemuDomainCheckpointLoad: Remove stale comment

Peter Krempa pkrempa at redhat.com
Tue Dec 8 15:34:42 UTC 2020


We decided to not do metadata-less checkpoints and checking whether the
metadata is consistent is done once the data is actually needed. Remove
the comment.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_driver.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0e5d7423dc..58c376fbe5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -533,13 +533,6 @@ qemuDomainCheckpointLoad(virDomainObjPtr vm,
                        vm->def->name);
     virDomainCheckpointSetCurrent(vm->checkpoints, current);

-    /* Note that it is not practical to automatically construct
-     * checkpoints based solely on qcow2 bitmaps, since qemu does not
-     * track parent relations which we find important in our metadata.
-     * Perhaps we could double-check that our just-loaded checkpoint
-     * metadata is consistent with existing qcow2 bitmaps, but a user
-     * that changes things behind our backs deserves what happens. */
-
     virResetLastError();

     ret = 0;
-- 
2.29.2




More information about the libvir-list mailing list