[libvirt PATCH] qemu: Simplify size check for ppc64 NVDIMMs

Andrea Bolognani abologna at redhat.com
Wed Dec 9 10:53:06 UTC 2020


On Mon, 2020-12-07 at 16:18 -0300, Daniel Henrique Barboza wrote:
> On 12/7/20 2:07 PM, Andrea Bolognani wrote:
> > +++ b/src/qemu/qemu_domain.c
> > @@ -5363,7 +5363,7 @@ qemuDomainNVDimmAlignSizePseries(virDomainMemoryDefPtr mem)
> >       /* Align down guest_area. 256MiB is the minimum size. Error
> >        * out if target_size is smaller than 256MiB + label_size,
> >        * since aligning it up will cause QEMU errors. */
> > -    if (mem->size < (ppc64AlignSize + mem->labelsize)) {
> > +    if (guestArea < ppc64AlignSize) {
> 
> Makes sense. I suggest to simplify the comment right above it as well:
> 
>         /* Align down guest_area. We can't align down if guest_area is
>          * smaller than the 256MiB alignment. */
>         if (guestArea < ppc64AlignSize) {
>         (...)
> 
> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

Thanks, I've updated the comment as you suggested and pushed the
change.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list