[libvirt PATCH 3/3] hyperv: remove duplicit addr check

Ján Tomko jtomko at redhat.com
Thu Dec 10 09:41:10 UTC 2020


We already check addr is not negative right after filling
its value. There's no need to check it before using it too.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
Fixes: a7a1d1f59e8ba2d8a3ed920ef595ccdfb0d8feb6
---
 src/hyperv/hyperv_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index c2c103aa3b..1200bf02ff 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -561,9 +561,6 @@ hypervDomainDefParsePhysicalDisk(hypervPrivate *priv,
     driveNumberStr = g_strdup_printf("%u", diskdrive->data->DriveNumber);
     virDomainDiskSetSource(disk, driveNumberStr);
 
-    if (addr < 0)
-        goto cleanup;
-
     if (controller->data->ResourceType == MSVM_RASD_RESOURCETYPE_PARALLEL_SCSI_HBA) {
         for (i = 0; i < HYPERV_MAX_SCSI_CONTROLLERS; i++) {
             if (controller == scsiControllers[i]) {
-- 
2.26.2




More information about the libvir-list mailing list