[PATCH 2/3] domain_conf: Allow to look up virtio-block devices by their CCW address

[Michal Privoznik]

On 11/25/20 12:06 PM, Thomas Huth wrote:
> On s390x, devices are attached to the channel IO subsytem by default,
> so we need to look up the devices via their CCW address there instead
> of using PCI.
> 
> This fixes "virsh domfsinfo" on s390x for virtio-block devices (the first
> attempt from commit f8333b3b0a7 did it in the wrong way, reporting the
> device name on the guest side instead of the target name on the host side).
> 
> Fixes: f8333b3b0a ("qemu: Fix domfsinfo for non-PCI device information ...")
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1858771

Nit pick, we tend to use Resolves: for bugs.

> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
>   src/conf/domain_conf.c | 10 +++++++++-
>   src/conf/domain_conf.h |  2 ++
>   src/qemu/qemu_driver.c |  8 +++++---
>   3 files changed, 16 insertions(+), 4 deletions(-)

I've also needed to adapt one more call of virDomainDiskByAddress() 
because of yet another of Marc-Andre's patch I've merged :-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal