[PATCH libvirt v4 09/12] node_device: refactor address retrieval of node device

Boris Fiuczynski fiuczy at linux.ibm.com
Thu Dec 10 17:45:57 UTC 2020


On 12/10/20 1:01 PM, John Ferlan wrote:
> Coverity got pretty grumpy this morning with RESOURCE_LEAKS due to
> override of @addr as changing from a break; inside a switch/case
> statement sent us back to the for statement rather than outside the loop
> which would occur on the break; inside the if {} else if {}
> 
> Suggestion... add "&& addr != NULL" as an additional for loop exit.
> 
> John

Thanks John.
I sent a patch with your suggested change slightly modified.

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





More information about the libvir-list mailing list