[PATCH 5/5] util: minor comment/formatting changes to virNetDevTapCreate()

Laine Stump laine at redhat.com
Wed Dec 16 01:27:23 UTC 2020


The comment about auto-generating names was obsoleted by recent
changes, and there was an unnecessary set of braces around a single
line conditional body.

Signed-off-by: Laine Stump <laine at redhat.com>
---
 src/util/virnetdevtap.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index cca2f614fe..8649978e53 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -174,15 +174,14 @@ int virNetDevTapCreate(char **ifname,
     int ret = -1;
     int fd = -1;
 
-    /* if ifname is "vnet%d", then auto-generate a name for the new
+    /* if ifname is empty, then auto-generate a name for the new
      * device (the kernel could do this for us, but has a bad habit of
      * immediately re-using names that have just been released, which
-     * can lead to race conditions).
-     * if ifname is just a user-provided name, virNetDevGenerateName
-     * leaves it unchanged. */
-    if (virNetDevGenerateName(ifname, VIR_NET_DEV_GEN_NAME_VNET) < 0) {
+     * can lead to race conditions).  if ifname is just a
+     * user-provided name, virNetDevGenerateName leaves it
+     * unchanged. */
+    if (virNetDevGenerateName(ifname, VIR_NET_DEV_GEN_NAME_VNET) < 0)
         return -1;
-    }
 
     if (!tunpath)
         tunpath = "/dev/net/tun";
-- 
2.28.0




More information about the libvir-list mailing list