[PATCH 04/10] virlease: Use virTrimSpaces() instead of open coded alternative

Michal Privoznik mprivozn at redhat.com
Fri Dec 18 15:09:10 UTC 2020


In virLeaseNew() we are trying to remove trailing space (per
comment it may happen that older versions of dnsmasq put it into
an env variable). Well, instead of open coding it, we can use
virTrimSpaces().

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virlease.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virlease.c b/src/util/virlease.c
index f01cf5b9bd..edfdc6477a 100644
--- a/src/util/virlease.c
+++ b/src/util/virlease.c
@@ -226,8 +226,7 @@ virLeaseNew(virJSONValuePtr *lease_ret,
 
         /* Removed extraneous trailing space in DNSMASQ_LEASE_EXPIRES
          * (dnsmasq < 2.52) */
-        if (exptime[strlen(exptime) - 1] == ' ')
-            exptime[strlen(exptime) - 1] = '\0';
+        virTrimSpaces(exptime, NULL);
     }
 
     if (!exptime ||
-- 
2.26.2




More information about the libvir-list mailing list