[PATCH 15/19] qemu: block: Add validator for bitmap chains accross backing chains

Ján Tomko jtomko at redhat.com
Mon Feb 3 12:46:23 UTC 2020


On Fri, Jan 31, 2020 at 03:31:19PM +0100, Peter Krempa wrote:
>Add a validator which checks that a bitmap spanning multiple backing
>chain members doesn't look broken. The current rules are that no
>intermediate birmaps are missing (unfortunately it's hard to know
>whether the topmost or bottommost bitmap is missing) and none of the
>components is inconsistent.
>
>We can obviously improve it over time.
>
>The validator is also tested against the existing bitmap data we have
>for the backup merging test as well as some of the existing broken
>bitmap synthetic test cases.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_block.c | 41 +++++++++++++++++++++++++
> src/qemu/qemu_block.h |  5 ++++
> tests/qemublocktest.c | 70 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 116 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200203/4974dded/attachment-0001.sig>


More information about the libvir-list mailing list