[PATCH 9/9] virDomainDiskTranslateSourcePool: Translate 'VOLUME' disks in whole backing chain

Ján Tomko jtomko at redhat.com
Wed Feb 5 15:13:49 UTC 2020


On Wed, Feb 05, 2020 at 02:41:00PM +0100, Peter Krempa wrote:
>Now that we accept full backing chains on input nothing should prevent
>users from also using disk type 'VOLUME' for specifying the backing
>images.

s/VOLUME/volume/g

No need to yell in the commit summary if the XML value is lowercase.

>
>Do the translation for the whole backing chain.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_conf.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 7bd86d67e5..46062e3969 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -31560,18 +31560,20 @@ int
> virDomainDiskTranslateSourcePool(virDomainDiskDefPtr def)
> {
>     g_autoptr(virConnect) conn = NULL;
>+    virStorageSourcePtr n;
>
>-    if (def->src->type != VIR_STORAGE_TYPE_VOLUME)
>-        return 0;
>-
>-    if (!def->src->srcpool)
>-        return 0;
>+    for (n = def->src; virStorageSourceIsBacking(n); n = n->backingStore) {
>+        if (n->type != VIR_STORAGE_TYPE_VOLUME || !n-> srcpool)

Extra space ------------------------------------------```

>+            continue;
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200205/9bbf9e6b/attachment-0001.sig>


More information about the libvir-list mailing list