[libvirt PATCH v2 43/56] util: conditionalize FD stream to exclude WIN32

[Daniel P. Berrangé]

On Fri, Jan 31, 2020 at 04:13:45PM +0100, Pavel Hrdina wrote:
> On Tue, Jan 28, 2020 at 01:11:24PM +0000, Daniel P. Berrangé wrote:
> > Almost none of the virFDStream code will actually work
> > on WIN32 builds, nor is it used except for in the
> > virtualbox driver for screenshots. It is simpler to
> > wrap it all in a '#ifndef WIN32'.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/util/virfdstream.c | 122 +++++++++++++++++++++++++++++++----------
> >  1 file changed, 93 insertions(+), 29 deletions(-)
> 
> If we are OK with breaking screenshots on virtualbox.  I guess that if
> someone is really using it we will have a bug report and we can solve it.
> 
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>

I forgot we don't even support virtualbox on Windows any more, since
we moved it into libvirtd & we don't build libvirtd on Windows.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|