[libvirt PATCH] tests: fix deadlock in eventtest

Daniel P. Berrangé berrange at redhat.com
Thu Feb 6 12:24:52 UTC 2020


On Thu, Feb 06, 2020 at 01:22:28PM +0100, Pavel Hrdina wrote:
> There is a race deadlock in eventtest after the recent rewrite to drop
> GNULIB from libvirt code base.
> 
> The issue happens when the callbacks testPipeReader() or testTimer()
> are called before waitEvents() starts waiting on `eventThreadCond`.
> It will never happen because the callbacks are already done and there
> is nothing that will signal the condition again.
> 
> Reported-by: Peter Krempa <pkrempa at redhat.com>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  tests/eventtest.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list