[PATCH] qemuBlockStorageSourceGetBackendProps: Report errors on all switch cases

Ján Tomko jtomko at redhat.com
Thu Feb 6 15:59:48 UTC 2020


On Thu, Feb 06, 2020 at 10:24:31AM +0100, Peter Krempa wrote:
>Few switch cases returned failure but didn't report an error. For a
>situation when the backingStore type='volume' was not translated the
>following error would occur:
>
> $ virsh start VM
> error: Failed to start domain VM
> error: An error occurred, but the cause is unknown
>
>After this patch:
>
> $ virsh start VM
> error: Failed to start domain VM
> error: internal error: storage source pool 'tmp' volume 'pull3.qcow2' is not translated
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_block.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200206/89ab4bc9/attachment-0001.sig>


More information about the libvir-list mailing list