[PATCH v1 01/14] vircgroup: add virCgroupSetupBlkioTune()

Cole Robinson crobinso at redhat.com
Tue Feb 11 22:35:47 UTC 2020


On 2/11/20 4:21 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 2/11/20 11:35 AM, Cole Robinson wrote:
>> On 2/11/20 7:28 AM, Daniel Henrique Barboza wrote:
>>>
> 
> [...]
> 
>>
>> I asked about this case in December, danpb suggested creating a new
>> src/hypervisor/ directory for containing shared driver code like this:
>>
>> https://www.redhat.com/archives/libvir-list/2019-December/msg00817.html
> 
> Thanks, I'm going for it.
> 
> Do you have any suggestions for the file names?  I see that you mentioned
> "domain_cgroup" in that thread, thus I'm thinking about creating a new
> src/hypervisor/domain_cgroup.c for the shared code between lxc_cgroup.c and
> qemu_cgroup.c.
> 
> I'm also considering a src/hypervisor/domain_driver.c for the driver common
> code between lxc_driver.c and qemu_driver.c that I ended up finding in this
> work.
> 

Those both sound reasonable to me.

Thanks,
Cole




More information about the libvir-list mailing list