[libvirt PATCH 03/10] qemu: save/restore original error when recovering from failed bridge attach

Ján Tomko jtomko at redhat.com
Mon Feb 17 06:58:51 UTC 2020


On Sun, Feb 16, 2020 at 11:22:52PM -0500, Laine Stump wrote:
>Not only was the original error code destroyed in the case of
>encountering an error during recovery from a failed attach to the
>bridge (and then *that* error was destroyed by logging a *second*
>error about the failure to recover - virNetDevBridgeAddPort() already
>logs an error, so the one about failing to recover was redundant), but
>if the recovery was successful, the function would then return success
>to the caller even though it had failed.

Fixes: 2711ac87160d7ac7d550c57f4339e6c6749942fa
(overwritten errors were introduced along with this functionality)
Fixes: 6bde0a1a37424c84492658223ff845b1ebb0e25c
(the wrong return value was introduced by a refactor)

>
>Signed-off-by: Laine Stump <laine at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200217/344dd71f/attachment-0001.sig>


More information about the libvir-list mailing list