[libvirt PATCH 05/10] conf: parse/format <portOptions isolated='yes|no'/>

Ján Tomko jtomko at redhat.com
Tue Feb 18 17:39:24 UTC 2020


On Sun, Feb 16, 2020 at 11:22:54PM -0500, Laine Stump wrote:
>This is a very simple thing to parse and format, but needs to be done
>in 4 places, so two trivial utility functions have been made that can
>be called from all the higher level parser/formatters:
>
>  <domain><interface>
>  <domain><interface><actual> (only in domain status)
>  <network>
>  <networkport>
>
>Signed-off-by: Laine Stump <laine at redhat.com>
>---
> docs/schemas/domaincommon.rng                 |  3 +
> docs/schemas/network.rng                      |  3 +
> docs/schemas/networkcommon.rng                | 11 ++++
> docs/schemas/networkport.rng                  |  3 +
> src/conf/domain_conf.c                        | 19 ++++++
> src/conf/domain_conf.h                        |  4 ++
> src/conf/network_conf.c                       | 32 ++++++++++
> src/conf/network_conf.h                       |  9 +++
> src/conf/virnetworkportdef.c                  |  3 +
> src/conf/virnetworkportdef.h                  |  1 +
> src/libvirt_private.syms                      |  1 +
> tests/networkxml2xmlin/isolated-ports.xml     |  7 +++
> tests/networkxml2xmlout/isolated-ports.xml    |  7 +++
> tests/networkxml2xmltest.c                    |  1 +
> tests/qemuxml2argvdata/net-isolated-port.xml  | 34 ++++++++++
> .../net-isolated-port.x86_64-latest.xml       | 63 +++++++++++++++++++
> tests/qemuxml2xmltest.c                       |  1 +
> 17 files changed, 202 insertions(+)
> create mode 100644 tests/networkxml2xmlin/isolated-ports.xml
> create mode 100644 tests/networkxml2xmlout/isolated-ports.xml
> create mode 100644 tests/qemuxml2argvdata/net-isolated-port.xml
> create mode 100644 tests/qemuxml2xmloutdata/net-isolated-port.x86_64-latest.xml
>

Not a fan of multi-word elements, because they bring up our
inconsistency in using camelCase vs snake_case.

But I assume you chose the name to make it compatible with all four
containing elements.

Would something like:
<networkport>
   <port isolated='yes'/>
</networkport>
look too odd?

Code-wise:
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200218/c1097a2b/attachment-0001.sig>


More information about the libvir-list mailing list