[PATCH 2/9] virStorageFileGetMetadataRecurse: Remove impossible error report

Eric Blake eblake at redhat.com
Wed Feb 19 15:46:06 UTC 2020


On 2/17/20 11:13 AM, Peter Krempa wrote:
> We call virStorageFileSupportsBackingChainTraversal which already checks
> that the 'storageFileRead' callback is non-NULL, which in turn means
> that virStorageFileRead will not return -2.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/util/virstoragefile.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
> 

Concur that it was dead code.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list