[libvirt PATCH 5/7] virsystemdtest: do not leak socket path

Ján Tomko jtomko at redhat.com
Sat Feb 22 00:24:10 UTC 2020


Use an autofree'd helper variable to store the socket path
and free it after the function finishes.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
Fixes: 5b8569dd6e284b9159c701e8bffafb196983fc4a
---
 tests/virsystemdtest.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c
index a9b02af7db..2ba288d032 100644
--- a/tests/virsystemdtest.c
+++ b/tests/virsystemdtest.c
@@ -554,12 +554,15 @@ testActivation(bool useNames)
     size_t nfds = 0;
     g_autoptr(virSystemdActivation) act = NULL;
     g_auto(virBuffer) names = VIR_BUFFER_INITIALIZER;
+    g_autofree char *demo_socket_path = NULL;
 
     virBufferAddLit(&names, "demo-unix.socket");
 
     if (testActivationCreateFDs(&sockUNIX, &sockIP, &nsockIP) < 0)
         return -1;
 
+    demo_socket_path = virNetSocketGetPath(sockUNIX);
+
     for (i = 0; i < nsockIP; i++)
         virBufferAddLit(&names, ":demo-ip.socket");
 
@@ -576,7 +579,7 @@ testActivation(bool useNames)
 
     map[0].name = "demo-unix.socket";
     map[0].family = AF_UNIX;
-    map[0].path = virNetSocketGetPath(sockUNIX);
+    map[0].path = demo_socket_path;
 
     map[1].name = "demo-ip.socket";
     map[1].family = AF_INET;
-- 
2.24.1




More information about the libvir-list mailing list