[libvirt PATCH 2/7] libxl: conf: move default keepalive settings to libxlDriverConfigNew

Ján Tomko jtomko at redhat.com
Sat Feb 22 14:25:06 UTC 2020


These hardcoded defaults do not need to be read from
the file. Move them out of libxlDriverConfigLoadFile.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/libxl/libxl_conf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 56deca7b7c..9c722342ba 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -1763,6 +1763,10 @@ libxlDriverConfigNew(void)
         goto error;
     cfg->firmwares[cfg->nfirmwares - 1]->name = g_strdup(LIBXL_FIRMWARE_DIR "/hvmloader");
 
+    /* defaults for keepalive messages */
+    cfg->keepAliveInterval = 5;
+    cfg->keepAliveCount = 5;
+
     return cfg;
 
  error:
@@ -1786,10 +1790,6 @@ int libxlDriverConfigLoadFile(libxlDriverConfigPtr cfg,
 {
     g_autoptr(virConf) conf = NULL;
 
-    /* defaults for keepalive messages */
-    cfg->keepAliveInterval = 5;
-    cfg->keepAliveCount = 5;
-
     /* Check the file is readable before opening it, otherwise
      * libvirt emits an error.
      */
-- 
2.24.1




More information about the libvir-list mailing list