[PATCH v2 01/14] vircgroup.c: adding virCgroupSetupBlkioDevice* helpers

Ján Tomko jtomko at redhat.com
Sun Feb 23 12:14:51 UTC 2020


s/adding/add/

On Mon, Feb 17, 2020 at 04:29:08PM -0500, Daniel Henrique Barboza wrote:
>The current use of the functions that sets and gets

*set, *get

>BlkioDevice attributes is doing a set(), following by
>a get() of the same parameter right after. This is done
>because there is no guarantee that the kernel will accept
>the desired value given by the set() call, thus we need to
>execute a get() right after to get the actual value.
>
>This patch adds helpers inside vircgroup.c to execute these
>operations. Next patch will use these helpers to reduce
>code repetition in LXC and QEMU files.
>
>Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>---
> src/libvirt_private.syms |  5 +++
> src/util/vircgroup.c     | 85 ++++++++++++++++++++++++++++++++++++++++
> src/util/vircgroup.h     | 20 ++++++++++
> 3 files changed, 110 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200223/a0ae08ac/attachment-0001.sig>


More information about the libvir-list mailing list