[jenkins-ci PATCH 0/8] lcitool: Support MinGW cross-build Dockerfiles

Ján Tomko jtomko at redhat.com
Mon Feb 24 00:58:32 UTC 2020


On Mon, Feb 10, 2020 at 06:18:09PM +0100, Andrea Bolognani wrote:
>More details in the commit message for patch 7/8.
>
>Pavel pointed out today that the current method of triggering MinGW
>builds using our CI scaffolding, eg.
>
>  $ make ci-build at fedora-30 CI_CONFIGURE=mingw64-configure
>
>is easy to get wrong and not very discoverable, so I took that as
>motivation to implement a change that I had been thinking about for
>a long time anyway. The new usage will be
>
>  $ make ci-build at fedora-30-cross-mingw64
>
>which aligns with how we're already doing cross-builds for other
>architectures and is discoverable via 'make ci-list-images'.
>
>The implementation is not the prettiest, but the Dockerfile
>generator in general could use some love so I don't think this
>improvement should be blocked because of that; I'll try to spend
>some time refactoring and cleaning up once this has been merged.
>
>Andrea Bolognani (8):
>  lcitool: Introduce cross_arch local variable
>  lcitool: Change check for pip_pkgs formatting
>  lcitool: Separate computation and formatting
>  lcitool: Introduce _dockerfile_format()
>  lcitool: Introduce _dockerfile_build_varmap()
>  lcitool: Add RPM-specific _dockerfile_build_varmap() variant
>  lcitool: Support MinGW cross-build Dockerfiles on Fedora
>  lcitool: Add more checks to _action_dockerfile()
>
> guests/lcitool | 219 ++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 172 insertions(+), 47 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200224/971bde6f/attachment-0001.sig>


More information about the libvir-list mailing list