[libvirt PATCH] esx: Same order of arguments in definition and declaration

Ján Tomko jtomko at redhat.com
Mon Feb 24 09:47:18 UTC 2020


On Sun, Feb 23, 2020 at 12:22:25AM +0100, Rikard Falkeborn wrote:
>The order of arguments were not the same in the definition and
>declaration. All callers use the same order as the definition, so there
>is no bug, but change the function declaration to match the
>implementation to avoid confusion.
>

Did you find it visually, or using cppcheck? :)

>Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com>
>---
> src/esx/esx_vi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

and pushed. Congrats on your first patch!

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200224/387d6e54/attachment-0001.sig>


More information about the libvir-list mailing list