[PATCH 0/3] security: Don't fail if locking a file on NFS mount fails

Peter Krempa pkrempa at redhat.com
Tue Feb 25 08:28:33 UTC 2020


On Fri, Feb 21, 2020 at 10:33:00 +0100, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (3):
>   virSecurityManagerMetadataLock: Store locked paths
>   security: Don't remember seclabel for paths we haven't locked
>     successfully
>   security: Don't fail if locking a file on NFS mount fails

I'm not quite happy about the technical debt this series is adding and
the code itself even had before. Tracking the paths and filedescriptors
in two separate arrays is one of them. The abduance of existing and
added n^2 algorithms is another. The fact that the metadata locking
function is modifying the order of the paths in the argument is also
weird and undocumented.

series:

Reviewed-by: Peter Krempa <pkrempa at redhat.com>

as this is fixing a real bug oVirt is hitting.




More information about the libvir-list mailing list