[PATCH 5/8] qemuCheckpointDiscardBitmaps: Use correct field for checkpoint bitmap name

Peter Krempa pkrempa at redhat.com
Fri Feb 28 13:39:57 UTC 2020


The code deleting checkpoints needs the name of the parent checkpoint's
disk's bitmap but was using the disk alias instead. This would create
wrong bitmaps after deleting some checkpoints.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_checkpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 32b0ab0faf..378f6c147e 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -283,7 +283,7 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
          * ancestor. */
         if ((parentchkdisk = qemuCheckpointFindActiveDiskInParent(vm, parent,
                                                                   chkdisk->name)))
-            parentbitmap = parentchkdisk->name;
+            parentbitmap = parentchkdisk->bitmap;

         if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeData,
                                              chkdisk->bitmap, parentbitmap,
-- 
2.24.1




More information about the libvir-list mailing list