[PATCH 2/2] qemu_shim: Ignore SIGPIPE

Michal Privoznik mprivozn at redhat.com
Fri Feb 28 15:56:01 UTC 2020


I've found that if my virtlogd is socket activated but the daemon
doesn't run yet, then the virt-qemu-run is killed right after it
tries to start the domain. The problem is that because the default
setting is to use virtlogd, the domain create code tries to
connect to virtlogd socket, which in turn tries to detect who is
connecting (virNetSocketGetUNIXIdentity()) and as a part of it,
it will try to open /proc/${PID_OF_SHIM}/stat which is denied by
SELinux:

  type=AVC msg=audit(1582903501.927:323): avc:  denied  { search } for  \
  pid=1210 comm="virtlogd" name="1843" dev="proc" ino=37224 \
  scontext=system_u:system_r:virtlogd_t:s0-s0:c0.c1023 \
  tcontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tclass=dir \
  permissive=0

Virtlogd reacts by closing the connection which the shim sees as
SIGPIPE. Since the default response to the signal is Term, we
don't even get to reporting any error nor to removing the
temporary directory.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_shim.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_shim.c b/src/qemu/qemu_shim.c
index 4f06ae952c..d8f3902874 100644
--- a/src/qemu/qemu_shim.c
+++ b/src/qemu/qemu_shim.c
@@ -150,6 +150,7 @@ int main(int argc, char **argv)
     signal(SIGINT, qemuShimSigShutdown);
     signal(SIGQUIT, qemuShimSigShutdown);
     signal(SIGHUP, qemuShimSigShutdown);
+    signal(SIGPIPE, SIG_IGN);
 
     if (root == NULL) {
         if (!(root = g_dir_make_tmp("virt-qemu-run-XXXXXX", &error))) {
-- 
2.24.1




More information about the libvir-list mailing list