[libvirt] [PATCH v2 0/5] Remove the last "no_memory" label

Fabiano Fidêncio fidencio at redhat.com
Thu Jan 2 15:00:30 UTC 2020

This series touches virfirewall.c, the last place where a no_memory
label can be found.

The series:
- Gets rid of setting and checking for ENOMEM as a firewall's error;
- Use g_auto / g_autofree in a few different places;
- Adapt ADD_ARG() macro as VIR_RESIZE_N() just aborts in case of OOM;
- Remove no_memory mention from the hacking guide;

Changes since v1:
- Daniel suggested to get rid of ADD_ARG(). Instead of doing so, I've
  adapted the macro (as it does more than just a realloc) and, by doing
  so, got rid of the no_memory labels;
- Dropped:
  - util: Rename 'no_memory' label to 'cleanup'
- Added:
  - util: Adapt ADD_ARG() macro

Fabiano Fidêncio (5):
  util: Don't set/check for ENOMEM as a firewall error
  util: Use g_auto/g_autofree in virFirewallAddRuleFullV()
  util: Use g_auto in virFirewallStartTransaction()
  util: Adapt ADD_ARG() macro
  docs: Remove mention to no_memory label

 docs/hacking.html.in   |  1 -
 src/util/virfirewall.c | 65 +++++++++++-------------------------------
 2 files changed, 16 insertions(+), 50 deletions(-)


More information about the libvir-list mailing list