[libvirt] [PATCH] virsh: Add a completer for `domifaddr` --source parameter.
Erik Skultety
eskultet at redhat.com
Fri Jan 3 12:40:34 UTC 2020
On Thu, Jan 02, 2020 at 12:07:06PM -0300, Julio Faracco wrote:
> The command `domifaddr` can use three different sources to grab IP
> address of a Virtual Machine: lease, agent and arp. This parameter does
> not have a completer function to return source options.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
...
> +
> +char **
> +virshDomainIfAddrSourceCompleter(vshControl *ctl,
I'd stay consistent with the existing naming scheme we have in place and expand
'If' to 'Interface' --> virshDomainInterfaceAddrSourceCompleter.
Changed and pushed.
Reviewed-by: Erik Skultety <eskultet at redhat.com>
More information about the libvir-list
mailing list