[libvirt] [PATCH v2 11/12] Fix bhyvexml2argvtest
Daniel P. Berrangé
berrange at redhat.com
Fri Jan 3 14:34:29 UTC 2020
On Thu, Jan 02, 2020 at 05:46:34PM +0000, Ryan Moeller wrote:
> Signed-off-by: Ryan Moeller <ryan at iXsystems.com>
> ---
> tests/bhyvexml2argvtest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c
> index 3c9c61f024..9e7eb218b8 100644
> --- a/tests/bhyvexml2argvtest.c
> +++ b/tests/bhyvexml2argvtest.c
> @@ -51,11 +51,11 @@ static int testCompareXMLToArgvFiles(const char *xml,
>
> conn->privateData = &driver;
>
> - cmd = virBhyveProcessBuildBhyveCmd(conn, vmdef, false);
> + cmd = virBhyveProcessBuildBhyveCmd(&driver, vmdef, false);
> if (vmdef->os.loader)
> ldcmd = virCommandNew("dummy");
> else
> - ldcmd = virBhyveProcessBuildLoadCmd(conn, vmdef, "<device.map>",
> + ldcmd = virBhyveProcessBuildLoadCmd(&driver, vmdef, "<device.map>",
> &actualdm);
>
> if ((cmd == NULL) || (ldcmd == NULL)) {
We need tests to be successfully buildable at every step, so that
"git bisect" can wrk reliably. So this needs squashing into patch 2
which first introduced the test build failure
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list