[libvirt] [PATCHv2 2/2] Introduce command 'virsh domstats --memory' for reporting memory BW

Daniel P. Berrangé berrange at redhat.com
Mon Jan 6 14:16:35 UTC 2020


On Thu, Jan 02, 2020 at 06:45:05PM +0800, Wang Huaqiang wrote:
> Introduce an option '--memory' for showing memory related
> information. The memory bandwidth infomatio is listed as:
> 
> Domain: 'libvirt-vm'
>  memory.bandwidth.monitor.count=4
>  memory.bandwidth.monitor.0.name=vcpus_0-4
>  memory.bandwidth.monitor.0.vcpus=0-4
>  memory.bandwidth.monitor.0.node.count=2
>  memory.bandwidth.monitor.0.node.0.id=0
>  memory.bandwidth.monitor.0.node.0.bytes.total=10208067584
>  memory.bandwidth.monitor.0.node.0.bytes.local=4807114752
>  memory.bandwidth.monitor.0.node.1.id=1
>  memory.bandwidth.monitor.0.node.1.bytes.total=8693735424
>  memory.bandwidth.monitor.0.node.1.bytes.local=5850161152
>  memory.bandwidth.monitor.1.name=vcpus_7
>  memory.bandwidth.monitor.1.vcpus=7
>  memory.bandwidth.monitor.1.node.count=2
>  memory.bandwidth.monitor.1.node.0.id=0
>  memory.bandwidth.monitor.1.node.0.bytes.total=853811200
>  memory.bandwidth.monitor.1.node.0.bytes.local=290701312
>  memory.bandwidth.monitor.1.node.1.id=1
>  memory.bandwidth.monitor.1.node.1.bytes.total=406044672
>  memory.bandwidth.monitor.1.node.1.bytes.local=229425152
> 
> Signed-off-by: Wang Huaqiang <huaqiang.wang at intel.com>
> ---
>  docs/manpages/virsh.rst          |  22 ++++++-
>  include/libvirt/libvirt-domain.h |   1 +
>  src/libvirt-domain.c             |  21 +++++++
>  src/qemu/qemu_driver.c           | 103 +++++++++++++++++++++++++++++++
>  tools/virsh-domain-monitor.c     |   7 +++
>  5 files changed, 152 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

> index e60003978a..78532c0eb8 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -2160,6 +2160,7 @@ typedef enum {
>      VIR_DOMAIN_STATS_BLOCK = (1 << 5), /* return domain block info */
>      VIR_DOMAIN_STATS_PERF = (1 << 6), /* return domain perf event info */
>      VIR_DOMAIN_STATS_IOTHREAD = (1 << 7), /* return iothread poll info */
> +    VIR_DOMAIN_STATS_MEMORY= (1 << 8), /* return domain memory info */

I fixed this missing whitespace when pushing.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list