[libvirt] [PATCH 1/2] vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg()

Michal Privoznik mprivozn at redhat.com
Mon Jan 6 14:24:19 UTC 2020


This function is not called outside of the source file where it's
defined. There's no need to export it.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/libvirt_private.syms      |  1 -
 src/util/vircgroupv2devices.c | 14 +-------------
 src/util/vircgroupv2devices.h |  5 -----
 3 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 74e3479842..9185e49fda 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1734,7 +1734,6 @@ virCgroupV1Register;
 virCgroupV2Register;
 
 # util/vircgroupv2devices.h
-virCgroupV2DevicesAttachProg;
 virCgroupV2DevicesAvailable;
 virCgroupV2DevicesCreateProg;
 virCgroupV2DevicesDetectProg;
diff --git a/src/util/vircgroupv2devices.c b/src/util/vircgroupv2devices.c
index dcf8925b18..7ea3c70efb 100644
--- a/src/util/vircgroupv2devices.c
+++ b/src/util/vircgroupv2devices.c
@@ -274,7 +274,7 @@ virCgroupV2DevicesLoadProg(int mapfd)
 }
 
 
-int
+static int
 virCgroupV2DevicesAttachProg(virCgroupPtr group,
                              int mapfd,
                              size_t max)
@@ -591,18 +591,6 @@ virCgroupV2DevicesAvailable(virCgroupPtr group G_GNUC_UNUSED)
 }
 
 
-int
-virCgroupV2DevicesAttachProg(virCgroupPtr group G_GNUC_UNUSED,
-                             int mapfd G_GNUC_UNUSED,
-                             size_t max G_GNUC_UNUSED)
-{
-    virReportSystemError(ENOSYS, "%s",
-                         _("cgroups v2 BPF devices not supported "
-                           "with this kernel"));
-    return -1;
-}
-
-
 int
 virCgroupV2DevicesDetectProg(virCgroupPtr group G_GNUC_UNUSED)
 {
diff --git a/src/util/vircgroupv2devices.h b/src/util/vircgroupv2devices.h
index 7b6cececc1..9d91256120 100644
--- a/src/util/vircgroupv2devices.h
+++ b/src/util/vircgroupv2devices.h
@@ -28,11 +28,6 @@ bool
 virCgroupV2DevicesAvailable(virCgroupPtr group)
     G_GNUC_NO_INLINE;
 
-int
-virCgroupV2DevicesAttachProg(virCgroupPtr group,
-                             int mapfd,
-                             size_t max);
-
 int
 virCgroupV2DevicesDetectProg(virCgroupPtr group);
 
-- 
2.24.1




More information about the libvir-list mailing list