[libvirt] [PATCH v1 00/26] remove more unneeded labels

Daniel Henrique Barboza danielhb413 at gmail.com
Mon Jan 6 21:57:24 UTC 2020


Hi,

This is a follow up of a cleanup I did last year [1], which was
more focused on 'cleanup' labels. In this one I covered all
labels that are simply a 'return' proxy call.

This wasn't a 'purge all return labels' series. Some of them
are still around in cases where they help the code flow
(like Jano suggested in the review at [2], for example).

I divided the series by module and by amount of changes made
to make it less daunting for reviews (although cases such as
domain_conf.c couldn't be avoided without splitting changes
in the same file in multiple patches). The maintainer is
welcome to squash the patches up as needed.


[1] https://www.redhat.com/archives/libvir-list/2019-October/msg01420.html
[2] https://www.redhat.com/archives/libvir-list/2019-November/msg00468.html


Daniel Henrique Barboza (26):
  bhyve: remove unneeded labels
  conf: remove unneeded labels
  conf: remove more unneeded labels
  conf/domain_conf.c: remove unneeded labels
  test/test_driver.c: remove unneeded labels
  storage: remove unneeded labels
  nwfilter: remove unneeded labels
  remote/remote_daemon_config.c: remove unneeded label
  hyperv/hyperv_wmi.c: remove unneeded labels
  locking/lock_driver_lockd.c: remove unneeded labels
  cpu/cpu_ppc64.c: remove unneeded label
  lxc: remove unneeded labels
  node_device: remove unneeded labels
  secret/secret_driver.c: remove unneeded label
  openvz: remove unneeded labels
  qemu: remove unneeded labels
  qemu: remove remaining unneeded labels
  vz/vz_sdk.c: remove unneeded labels
  vbox: remove unneeded labels
  security: remove unneeded labels
  util/virsysinfo.c: remove unneeded labels
  util: remove unneeded labels
  util: remove remaining unneeded labels
  logging: remove unneeded labels
  tests: remove unneeded labels
  examples: remove unneeded labels

 examples/c/misc/hellolibvirt.c             |  28 +--
 examples/c/misc/openauth.c                 |  22 +--
 src/bhyve/bhyve_device.c                   |  13 +-
 src/bhyve/bhyve_parse_command.c            |  47 ++---
 src/conf/capabilities.c                    |  14 +-
 src/conf/cpu_conf.c                        |  36 ++--
 src/conf/domain_addr.c                     |   9 +-
 src/conf/domain_conf.c                     | 192 +++++++--------------
 src/conf/interface_conf.c                  |   9 +-
 src/conf/network_conf.c                    |  45 ++---
 src/conf/networkcommon_conf.c              |  11 +-
 src/conf/nwfilter_conf.c                   |   3 +-
 src/conf/nwfilter_params.c                 |   5 +-
 src/conf/virnetworkobj.c                   |   7 +-
 src/cpu/cpu_ppc64.c                        |  12 +-
 src/hyperv/hyperv_wmi.c                    |  15 +-
 src/locking/lock_driver_lockd.c            |  16 +-
 src/logging/log_handler.c                  |   7 +-
 src/logging/log_manager.c                  |  14 +-
 src/lxc/lxc_container.c                    |   7 +-
 src/lxc/lxc_controller.c                   |  10 +-
 src/node_device/node_device_driver.c       |   4 +-
 src/node_device/node_device_hal.c          |  10 +-
 src/nwfilter/nwfilter_ebiptables_driver.c  |  11 +-
 src/nwfilter/nwfilter_learnipaddr.c        |   3 +-
 src/openvz/openvz_conf.c                   |  11 +-
 src/openvz/openvz_driver.c                 |  42 ++---
 src/qemu/qemu_capabilities.c               |  15 +-
 src/qemu/qemu_command.c                    |  93 +++++-----
 src/qemu/qemu_domain.c                     |  11 +-
 src/qemu/qemu_domain_address.c             |  52 +++---
 src/qemu/qemu_driver.c                     |  32 ++--
 src/qemu/qemu_hostdev.c                    |  11 +-
 src/qemu/qemu_hotplug.c                    |  15 +-
 src/qemu/qemu_migration_cookie.c           |  10 +-
 src/qemu/qemu_migration_params.c           |  11 +-
 src/remote/remote_daemon_config.c          | 101 ++++++-----
 src/secret/secret_driver.c                 |   6 +-
 src/security/security_dac.c                |  26 ++-
 src/security/security_selinux.c            |  26 ++-
 src/security/virt-aa-helper.c              |  41 ++---
 src/storage/storage_backend_iscsi_direct.c |   4 +-
 src/storage/storage_driver.c               |   4 +-
 src/test/test_driver.c                     |  51 +++---
 src/util/virhostcpu.c                      |   6 +-
 src/util/virnetdev.c                       |  13 +-
 src/util/virnetdevmacvlan.c                |   3 +-
 src/util/virnetdevtap.c                    |  15 +-
 src/util/virnetdevvportprofile.c           |  52 +++---
 src/util/virnetlink.c                      |   4 +-
 src/util/virpci.c                          |  14 +-
 src/util/virsocketaddr.c                   |  11 +-
 src/util/virstoragefile.c                  |   4 +-
 src/util/virsysinfo.c                      |  54 ++----
 src/util/virtpm.c                          |   5 +-
 src/util/virtypedparam.c                   |  14 +-
 src/util/viruuid.c                         |  13 +-
 src/vbox/vbox_MSCOMGlue.c                  |  11 +-
 src/vbox/vbox_snapshot_conf.c              |   9 +-
 src/vz/vz_sdk.c                            | 102 ++++-------
 tests/qemumonitortestutils.c               |  15 +-
 tests/testutilsqemu.c                      |   8 +-
 tests/virhostdevtest.c                     |  14 +-
 63 files changed, 564 insertions(+), 915 deletions(-)

-- 
2.24.1





More information about the libvir-list mailing list