[libvirt] [PATCH v1 14/26] secret/secret_driver.c: remove unneeded label

[Erik Skultety]

On Mon, Jan 06, 2020 at 06:57:38PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>  src/secret/secret_driver.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
> index 096672f114..5a93c3af82 100644
> --- a/src/secret/secret_driver.c
> +++ b/src/secret/secret_driver.c
> @@ -591,13 +591,13 @@ secretConnectSecretEventRegisterAny(virConnectPtr conn,
>      int callbackID = -1;
>
>      if (virConnectSecretEventRegisterAnyEnsureACL(conn) < 0)
> -        goto cleanup;
> +        return -1;
>
>      if (virSecretEventStateRegisterID(conn, driver->secretEventState,
>                                        secret, eventID, callback,
>                                        opaque, freecb, &callbackID) < 0)
> -        callbackID = -1;

Nitpick: inconsistent with the other driver equivalents. 'return -1' is okay,
but let's just focus only on the label like the other patches did.

Erik

> - cleanup:
> +        return -1;
> +
>      return callbackID;
>  }
>
> --
> 2.24.1
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list