[libvirt] [PATCH v1 00/26] remove more unneeded labels

Daniel Henrique Barboza danielhb413 at gmail.com
Tue Jan 7 12:25:15 UTC 2020

On 1/7/20 8:55 AM, Erik Skultety wrote:
> On Mon, Jan 06, 2020 at 06:57:24PM -0300, Daniel Henrique Barboza wrote:
>> Hi,
>> This is a follow up of a cleanup I did last year [1], which was
>> more focused on 'cleanup' labels. In this one I covered all
>> labels that are simply a 'return' proxy call.
>> This wasn't a 'purge all return labels' series. Some of them
>> are still around in cases where they help the code flow
>> (like Jano suggested in the review at [2], for example).
>> I divided the series by module and by amount of changes made
>> to make it less daunting for reviews (although cases such as
>> domain_conf.c couldn't be avoided without splitting changes
>> in the same file in multiple patches). The maintainer is
>> welcome to squash the patches up as needed.
> Right, that's what I will do. Like I mentioned in 01/26, I can imagine more
> thorough Glib-ification of some of the patches, there are many candidates with
> a simple straightforward way to convert and thus drop even more labels, but it
> was never the intent of this series and as such these adjustments can be done
> at any point in time independently.

I did a couple of Glib-fications last year on some QEMU files. What happens is that
the Glib-fication process ends up making more labels obsolete, then you can
do an extra step to remove them. Doing this work together with this series is
definitely possible, but it would produce an amount of patches/changes that would
be too hard to review.



> Reviewed-by: Erik Skultety <eskultet at redhat.com>

More information about the libvir-list mailing list