[libvirt] [PATCH 2/2] qemu: backup: roll-back checkpoint metadata if the checkpoint wasn't taken

[Daniel P. Berrangé]

On Mon, Jan 06, 2020 at 03:37:10PM +0100, Peter Krempa wrote:
> We insert the checkpoint metadata into the list of checkpoints prior to
> actually creating the on-disk bits. If the 'transaction' or any other
> steps done between inserting the checkpoint and creating the on-disk
> data fail we'd end up with an unusable checkpoint that would vanish
> after libvirtd restart.
> 
> Prevent this by rolling back the metadata if we didn't actually take and
> record the checkpoint.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_backup.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|